Add list types #13922
Closed
Add list types #13922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Oct 22, 2024
| union(dynamic(list_tl_static(dynamic)), list_tl_static(static)) | ||
|
|
||
| is_dynamic_list and only_list -> | ||
| :not_non_empty_list |
josevalim
reviewed
Oct 22, 2024
Comment on lines
+885
to
+891
| # Eliminate empty lists from the union TODO | ||
| defp list_normalize(dnf), do: dnf | ||
| # Enum.filter(dnf, fn {list_type, last_type, negs} -> | ||
| # not Enum.any?(negs, fn neg -> subtype?(list_type, neg) end) | ||
| # end) | ||
| # end | ||
| # |
There was a problem hiding this comment.
Suggested change
| # Eliminate empty lists from the union TODO | |
| defp list_normalize(dnf), do: dnf | |
| # Enum.filter(dnf, fn {list_type, last_type, negs} -> | |
| # not Enum.any?(negs, fn neg -> subtype?(list_type, neg) end) | |
| # end) | |
| # end | |
| # | |
| # TODO: Eliminate empty lists from the union TODO | |
| defp list_normalize(dnf), do: dnf | |
| # Enum.filter(dnf, fn {list_type, last_type, negs} -> | |
| # not Enum.any?(negs, fn neg -> subtype?(list_type, neg) end) | |
| # end) | |
| # end | |
josevalim
reviewed
Oct 22, 2024
| def list(_arg), do: %{bitmap: @bit_list} | ||
| def non_empty_list(_arg, _tail \\ empty_list()), do: %{bitmap: @bit_non_empty_list} | ||
|
|
||
| # TODO: check emptiness here? |
josevalim
reviewed
Oct 22, 2024
| [to_quoted(list_type), to_quoted(last_type)] | ||
| end | ||
|
|
||
| if Enum.empty?(negs) do |
There was a problem hiding this comment.
Suggested change
| if Enum.empty?(negs) do | |
| if negs == [] do |
josevalim
reviewed
Oct 22, 2024
| end | ||
| end | ||
|
|
||
| def list_to_quoted(dnf) do |
There was a problem hiding this comment.
Suggested change
| def list_to_quoted(dnf) do | |
| defp list_to_quoted(dnf) do |
|
Merged manually, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper list types:
list()list(integer())a (possibly empty) list of integersImproper lists:
list(integer(), atom())(a list of integers, with an atom at the tail)A type like
list(term(), term()includes both propers lists and improper lists (sinceterm()includesempty_list())Also includes
hdandtloperators, type-safe so using those on lists that may be empty will errorUsing
tlon a improper list likelist(integer(), atom())will return either a list of integers or anatom().The addition creates some warning for the compiler on patterns not matching, to be fixed :)