Skip to content

Clarify that charlists cannot be used as logger metadata #13977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

Clarify that charlists cannot be used as logger metadata #13977

merged 1 commit into from
Nov 7, 2024

Conversation

@sabiwara
Copy link
Contributor

@sabiwara sabiwara commented Nov 7, 2024

Clarifies the current behavior as pointed out in https://elixirforum.com/t/charlist-values-are-not-showing-up-in-logger-metadata/67256.

Alternatively, we could support it by removing this line (but it would crash on invalid charlists) or add a try/rescue with List.to_string?

josevalim
josevalim approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we ran into issue once we integrated with Erlang's logger, so for now I would only document the current behaviour.

@sabiwara sabiwara merged commit fbeccf9 into elixir-lang:main Nov 7, 2024
11 checks passed
@sabiwara sabiwara deleted the clarify-metadata branch November 7, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josevalim josevalim josevalim approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sabiwara @josevalim