Skip to content

Make protocol errors pretty #14003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Make protocol errors pretty #14003

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d7d036
Make protocol errors pretty
davydog187 Nov 20, 2024
886ba53
Update lib/elixir/lib/exception.ex
davydog187 Nov 20, 2024
07afa2c
Update lib/elixir/lib/exception.ex
davydog187 Nov 20, 2024
89e8d88
Update lib/elixir/lib/exception.ex
davydog187 Nov 20, 2024
c211861
Update exception.ex
davydog187 Nov 20, 2024
1fed203
fix formatter
davydog187 Nov 20, 2024
11d9944
fix the tests
davydog187 Nov 21, 2024
a6cc84c
indent the text
davydog187 Nov 21, 2024
08ed97e
Update lib/elixir/lib/exception.ex
josevalim Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/elixir/lib/exception.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ defmodule Exception do
defp rewrite_arg(arg) do
Macro.prewalk(arg, fn
{:%{}, meta, [__struct__: Range, first: first, last: last, step: step]} ->
{:..//, meta, [first, last, step]}
{:"..//", meta, [first, last, step]}

other ->
other
Expand Down Expand Up @@ -1997,11 +1997,11 @@ defmodule Protocol.UndefinedError do

@impl true
def message(%{protocol: protocol, value: value, description: description}) do
"protocol #{inspect(protocol)} not implemented for #{inspect(value)} of type " <>
"protocol #{inspect(protocol)} not implemented for #{inspect(value, pretty: true)} of type " <>
value_type(value) <> maybe_description(description) <> maybe_available(protocol)
end

defp value_type(%{__struct__: struct}), do: "#{inspect(struct)} (a struct)"
defp value_type(%{__struct__: struct}), do: "#{inspect(struct, pretty: true)} (a struct)"
defp value_type(value) when is_atom(value), do: "Atom"
defp value_type(value) when is_bitstring(value), do: "BitString"
defp value_type(value) when is_float(value), do: "Float"
Expand Down