Skip to content

Load modules for mix recompile all-at-once #14006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Load modules for mix recompile all-at-once #14006

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47c9b20
Load modules for mix recompile all-at-once
Nov 21, 2024
6816df3
Update lib/mix/lib/mix/compilers/elixir.ex
josevalim Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/mix/lib/mix/compilers/elixir.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,19 +373,26 @@ defmodule Mix.Compilers.Elixir do
Map.has_key?(stale_modules, module) ->
{[module | modules_to_recompile], modules_to_mix_check}

recompile? and Code.ensure_loaded?(module) and
function_exported?(module, :__mix_recompile__?, 0) ->
recompile? ->
{modules_to_recompile, [module | modules_to_mix_check]}

true ->
{modules_to_recompile, modules_to_mix_check}
end
end

_ = Code.ensure_all_loaded(modules_to_mix_check)

modules_to_recompile =
modules_to_recompile ++
for {:ok, {module, true}} <-
Task.async_stream(modules_to_mix_check, &{&1, &1.__mix_recompile__?()},
Task.async_stream(
modules_to_mix_check,
fn module ->
{module,
function_exported?(module, :__mix_recompile__?, 0) and
module.__mix_recompile__?()}
end,
ordered: false,
timeout: :infinity
) do
Expand Down
Loading