Skip to content

Rely on mtime to recompile app #14012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2024
Merged

Rely on mtime to recompile app #14012

merged 2 commits into from
Nov 25, 2024

Conversation

@josevalim
Copy link
Member

No description provided.

@dvic
Copy link
Contributor

dvic commented Nov 22, 2024

Won't this introduce the CI build cache issues as before? (#12056 (comment))

@josevalim
Copy link
Member Author

It should not make a difference. compile.elixir and compile.erlang already relies on mtime as well. That issue was more about avoid recompiling when the mtime changed but the contents were the same, but we still relied on mtime to see if something maybe changed.

@josevalim josevalim merged commit a6d7232 into main Nov 25, 2024
24 checks passed
@josevalim josevalim deleted the jv-rely-on-mtime-to-recompile-app branch November 25, 2024 10:34
@josevalim
Copy link
Member Author

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josevalim @dvic