Skip to content

Conversation

@ckampfe
Copy link
Contributor

@ckampfe ckampfe commented Dec 10, 2024

Support min and max in guards, for: #11985

How would you prefer this to be tested? I've looked through kernel_test.exs and guard_test.exs and I'm not seeing anything specific for guards that delegate to the Erlang builtin guards.

Thank you!

@whatyouhide
Copy link
Member

I’m ok with not testing this, as you said it's just delegating.

@josevalim josevalim merged commit 13285e9 into elixir-lang:main Dec 11, 2024
7 of 9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@ckampfe ckampfe deleted the min-max-guards branch December 11, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants