Skip to content

Fix mix escript.build when protocol consolidation is disabled #14098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Fix mix escript.build when protocol consolidation is disabled #14098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mix/lib/mix/tasks/escript.build.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ defmodule Mix.Tasks.Escript.Build do
{zip_path, consolidated[Path.basename(path)] || path}
end
else
[]
files
end
end

Expand Down
14 changes: 14 additions & 0 deletions lib/mix/test/mix/tasks/escript_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,20 @@ defmodule Mix.Tasks.EscriptTest do
end)
end

test "generate escript without protocol consolidation" do
in_fixture("escript_test", fn ->
push_project_with_config(Escript, consolidate_protocols: false)

Mix.Tasks.Escript.Build.run([])
assert_received {:mix_shell, :info, ["Generated escript escript_test with MIX_ENV=dev"]}
assert System.cmd("escript", ["escript_test"]) == {"TEST\n", 0}
assert count_abstract_code("escript_test") == 0

# Does not consolidate protocols
assert System.cmd("escript", ["escript_test", "--protocol", "Enumerable"]) == {"false\n", 0}
end)
end

test "generate escript with --no-compile option" do
in_fixture("escript_test", fn ->
push_project_with_config(Escript)
Expand Down
Loading