Better document AST metadata in Macro #14120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
approved these changes
Dec 27, 2024
lib/elixir/lib/macro.ex
Outdated
| character (either a newline or `;`). This entry may appear multiple times | ||
| in the same metadata if the expression is surround by parens | ||
| * `:format` - set to `:keyword` when an atom is defined as a keyword |
There was a problem hiding this comment.
It can also be :atom as of #13999.
|
We also added |
josevalim
commented
Dec 27, 2024
whatyouhide
approved these changes
Dec 27, 2024
Co-authored-by: Andrea Leopardi <[email protected]>
|
💚 💙 💜 💛 ❤️ |
josevalim
added a commit
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jonatanklosko