Improve warning for charlist deprecation #14160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current warning for single-quoted character lists is confusing because it appears to be a stylistic note instead of a deprecation warning. This commit updates the language to make the reasoning clearer and to more clearly describe what `mix format --migrate` will change about the users' code.
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jan 9, 2025
The current warning for single-quoted character lists is confusing because it appears to be a stylistic note instead of a deprecation warning. This commit updates the language to make the reasoning clearer and to more clearly describe what `mix format --migrate` will change about the users' code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused when I saw the current charlist warning and this PR slightly tweaks the language to make the reason for the warning clearer. Specifically I wanted to highlight that this is not a stylistic disagreement, but is about a deprecation, which the current language omits.
P.s. this is my first PR on elixir and would welcome feedback. A huge fan of the language and all of the work y'all do!