Skip to content

Improve warning for charlist deprecation #14160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Improve warning for charlist deprecation #14160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/elixir/src/elixir_tokenizer.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,9 +826,10 @@ handle_strings(T, Line, Column, H, Scope, Tokens) ->
NewScope =
case H of
$' ->
Message = "single-quoted strings represent charlists. "
Message = "using single-quoted strings to represent charlists is deprecated.\n"
"Use ~c\"\" if you indeed want a charlist or use \"\" instead.\n"
"You may run \"mix format --migrate\" to fix this warning automatically.",
"You may run \"mix format --migrate\" to change all single-quoted\n"
"strings to use the ~c sigil and fix this warning.",
prepend_warning(Line, Column-1, Message, InterScope);

_ ->
Expand Down
Loading