Mention the new type system in typespecs doc #14188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 15, 2025
Comment on lines
3
to
5
| Elixir is in the process of implementing its [own type system](./gradual-set-theoretic-types.md) based on set-theoretic types. Typespecs, which are described in the following document, are a distinct notation for declaring types and specifications based on Erlang. | ||
|
|
||
| Typespecs will be phased out as the set-theoretic type effort moves forward. |
There was a problem hiding this comment.
Suggested change
| Elixir is in the process of implementing its [own type system](./gradual-set-theoretic-types.md) based on set-theoretic types. Typespecs, which are described in the following document, are a distinct notation for declaring types and specifications based on Erlang. | |
| Typespecs will be phased out as the set-theoretic type effort moves forward. | |
| > Elixir is in the process of implementing its [own type system](./gradual-set-theoretic-types.md) based on set-theoretic types. Typespecs, which are described in the following document, are a distinct notation for declaring types and specifications based on Erlang. Typespecs may be phased out as the set-theoretic type effort moves forward. |
josevalim
approved these changes
Jan 15, 2025
|
Feel free to merge and, once you do, please backport! |
sabiwara
added a commit
to sabiwara/elixir
that referenced
this pull request
Jan 15, 2025
Done ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This discussion made me realize that today the doc for typespecs does not call out the fact this is the "old typesystem" and it doesn't represent the upcoming type system.
I can see how this might be confusing for people who haven't followed the type system discussions closely or are learning Elixir, and do not realize a) that these two are separate b) how they relate/differ
Feel free to modify the copy.