Support 2-arity options for Calendar.strftime/3 #14247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Feb 1, 2025
josevalim
reviewed
Feb 1, 2025
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for 2-arity functions for
Calendar.strftime/3options per this proposal.The result is that the options functions may be 1-arity and receive the term to be processed or 2-arity in which case they receive both the term and the datetime argument to
Calendar.strftime/3.The function documentation is updated but may well benefit from further work.
A single test case is added to verify that 2-arity functions are supported, and that the datetime is correctly passed to them. All tests are passing.