Skip to content

Conversation

@maennchen
Copy link
Member

@maennchen maennchen commented Feb 8, 2025

Follow up of #14241

  • Removes unused actions code
  • Declare special files correctly (docs, build tools etc.)
  • Remove default fallback rule (no file license header and no exception configured => error in CI)
  • Implement exception for binary files and test fixtures
  • Replace Unmanaged package manager with SpdxDocumentFile to improve fields like name and homepage in SPDX

Some more changes will need to be done in the future about declaring the erlang dependency and publish the correct purls, but that currently has an issue. (oss-review-toolkit/ort#9904) I'll open a PR about that once there's a working solution.

@maennchen maennchen force-pushed the jm/improve_sbom_details branch from abc0d9e to 2a7c850 Compare February 8, 2025 14:09
@maennchen maennchen marked this pull request as draft February 8, 2025 14:45
@maennchen
Copy link
Member Author

There's a small issue with the rules. Debugging...

@maennchen maennchen force-pushed the jm/improve_sbom_details branch from 2a7c850 to 2797d33 Compare February 9, 2025 12:53
@maennchen maennchen force-pushed the jm/improve_sbom_details branch from 2797d33 to 93ede06 Compare February 9, 2025 13:10
@maennchen maennchen marked this pull request as ready for review February 9, 2025 14:52
@josevalim
Copy link
Member

@maennchen just confirm, is this good to go?

@maennchen
Copy link
Member Author

@josevalim Yes, now it is. There was an issue around gitignore files. I’ll adress those upstream. (Not sure yet if it is an ORT or ScanCode Issue.)

@josevalim josevalim merged commit e45a1f2 into elixir-lang:main Feb 9, 2025
10 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@maennchen maennchen deleted the jm/improve_sbom_details branch February 9, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants