Skip to content

Fix regression when diffing nested improper lists #14292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Fix regression when diffing nested improper lists #14292

merged 1 commit into from
Feb 21, 2025

Conversation

@sabiwara
Copy link
Contributor

@sabiwara sabiwara commented Feb 20, 2025 •
edited
Loading

Close #14291

Should be backported after merge.

@sabiwara sabiwara merged commit b3cc618 into elixir-lang:main Feb 21, 2025
8 of 10 checks passed
@sabiwara sabiwara deleted the diff-improper-list branch February 21, 2025 14:08
sabiwara added a commit to sabiwara/elixir that referenced this pull request Feb 21, 2025
@sabiwara
Fix regression when diffing nested improper lists (elixir-lang#14292)
69990a5 
Close elixir-lang#14291
@sabiwara
Copy link
Contributor Author

Backported https://github.com/elixir-lang/elixir/commits/v1.18/

@grzuy grzuy mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josevalim josevalim josevalim approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExUnit assert crashing when trying to format AssertionError under some wierd condition with "improper list"

2 participants

@sabiwara @josevalim