Skip to content

Fix autocomplete crash when expanding struct with __MODULE__ #14308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Fix autocomplete crash when expanding struct with __MODULE__ #14308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f9bbb
Fix autocomplete crash when expanding struct with __MODULE__
lukaszsamson Mar 2, 2025
15d16de
add test
lukaszsamson Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/iex/lib/iex/autocomplete.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,16 +381,18 @@ defmodule IEx.Autocomplete do
case Code.Fragment.container_cursor_to_quoted(code) do
{:ok, quoted} ->
case Macro.path(quoted, &match?({:__cursor__, _, []}, &1)) do
[cursor, {:%{}, _, pairs}, {:%, _, [{:__aliases__, _, aliases}, _map]} | _] ->
[cursor, {:%{}, _, pairs}, {:%, _, [{:__aliases__, _, aliases = [h | _]}, _map]} | _]
when is_atom(h) ->
container_context_struct(cursor, pairs, aliases, shell)

[
cursor,
pairs,
{:|, _, _},
{:%{}, _, _},
{:%, _, [{:__aliases__, _, aliases}, _map]} | _
] ->
{:%, _, [{:__aliases__, _, aliases = [h | _]}, _map]} | _
]
when is_atom(h) ->
container_context_struct(cursor, pairs, aliases, shell)

[cursor, pairs, {:|, _, [{variable, _, nil} | _]}, {:%{}, _, _} | _] ->
Expand Down
3 changes: 3 additions & 0 deletions lib/iex/test/iex/autocomplete_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,9 @@ defmodule IEx.AutocompleteTest do
assert {:yes, ~c"ry: ", []} = expand(~c"%URI{path: \"foo\", que")
assert {:no, [], []} = expand(~c"%URI{path: \"foo\", unkno")
assert {:no, [], []} = expand(~c"%Unknown{path: \"foo\", unkno")

assert {:yes, [], _} = expand(~c"%__MODULE__{")
assert {:yes, [], _} = expand(~c"%__MODULE__.Some{")
end

test "completion for struct keys in update syntax" do
Expand Down
Loading