types.ex - improve warning message about defp defaults #14326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 12, 2025
…vate functions The original version of this warning did not mention that the warning applies to private functions only, this patch fixes that.
demerphq
force-pushed
the
yves/dep_unused_optional_params_warnings
branch
from
e9e31ab to
512401f
Compare
|
@josevalim I am pretty sure the test failure in this PR is not from my change. It seems to be from a deprecated warning from testing a deprecated feature. What should I do about this? |
|
@demerphq it is not related to your change however that's not the failure. GitHub Actions does not show all of the output on Windows and you have to click to view all to see the actual thing. It is in our todo list to track it down. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some text to the warning explaining it only affects private functions and that making the function public will silence the warning.