Fix URI.merge/2 to handle base URIs with scheme but without host #14344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 18, 2025
|
|
||
| def merge(%URI{host: nil}, _rel) do | ||
| def merge(%URI{scheme: nil}, _rel) do | ||
| raise ArgumentError, "you must merge onto an absolute URI" |
There was a problem hiding this comment.
I am not sure if this message is correct. Also, shouldn't be fine to merge into //foo/bar? Should we add a test for that?
There was a problem hiding this comment.
Regarding the error message: I believe the message has become more accurate with this change. But "base must be an absolute URI" might be clearer.
Regarding //foo/bar: Such a network-path reference, is still a relative URI and should IMO lead to this error when used as a base.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another fix for a
URI.merge/2issue that was uncovered by the W3C JSON-LD 1.1 Test suite.The current implementation incorrectly rejects base URIs with a scheme but without a host: