retry mix httpc with disabled middlebox_comp_mode #14357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Mar 24, 2025
lib/mix/lib/mix/utils.ex
Outdated
| request |> httpc_request(http_options) |> httpc_response() | ||
|
|
||
| {:error, {:failed_connect, [{:to_address, _}, {inet, _, {:tls_alert, _}}]}} | ||
| when inet in [:inet, :inet6] -> |
There was a problem hiding this comment.
Maybe less strict
{:error, {:failed_connect, [{:to_address, _}, {inet, _, reason}]}}
when inet in [:inet, :inet6] and elem(reason, 0) == :tls_alert ->or more strict
{:error, {:failed_connect, [{:to_address, _}, {inet, _, {:tls_alert, {:unexpected_message, _}}}]}}
when inet in [:inet, :inet6] ->matching?
Right now this error seems to always be {:tls_alert, _} but I couldn't find a record for it to future-proof it.
There was a problem hiding this comment.
I think less strict is good as it is plausible to add more elements to the tuple.
ruslandoga
changed the title
josevalim
reviewed
Mar 24, 2025
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14356
Similar to
inet<->inet6fallback, this PR adds retries ontls_alertwithmiddlebox_comp_mode: false