Skip to content

Improve coverage for Keyword.delete_first/2 #14412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Improve coverage for Keyword.delete_first/2 #14412

merged 1 commit into from
Apr 8, 2025

Conversation

@pnezis
Copy link
Contributor

@pnezis pnezis commented Apr 8, 2025

This seems to be the only uncovered line from Keyword (excluding the deprecated ones).

whatyouhide
whatyouhide approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah removing the empty clause makes sense, I think it's dead code right?

@josevalim josevalim merged commit 9449df8 into elixir-lang:main Apr 8, 2025
11 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whatyouhide whatyouhide whatyouhide approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pnezis @josevalim @whatyouhide