IEx.Helpers.process_info/1 #14418
Merged
IEx.Helpers.process_info/1 #14418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 9, 2025
josevalim
approved these changes
Apr 9, 2025
josevalim
reviewed
Apr 9, 2025
| end | ||
|
|
||
| defp print_process_overview(info) do | ||
| print_pane("Overview") |
There was a problem hiding this comment.
Oh, let's print the process itself in the overview, it is useful if you do Enum.map(pids, &process_info/1).
Co-authored-by: José Valim <[email protected]>
SteffenDE
commented
Apr 10, 2025
| end | ||
| end | ||
|
|
||
| defp print_process_stacktrace([]), do: :ok |
There was a problem hiding this comment.
Can this ever happen?
There was a problem hiding this comment.
maybe if the process is hibernating? 🤔 But I think it is a good clause to have anyway, it may happen in other scenarios.
SteffenDE
commented
Apr 10, 2025
Comment on lines
+951
to
+968
| defp pid_or_port_details(pid) when is_pid(pid), do: to_process_details(pid) | ||
| defp pid_or_port_details(name) when is_atom(name), do: to_process_details(name) | ||
| defp pid_or_port_details(port) when is_port(port), do: to_port_details(port) | ||
| defp pid_or_port_details(reference) when is_reference(reference), do: reference | ||
|
|
||
| defp to_process_details(pid) when is_pid(pid) do | ||
| case Process.info(pid, [:initial_call, :dictionary, :registered_name]) do | ||
| [{:initial_call, initial_call}, {:dictionary, dictionary}, {:registered_name, name}] -> | ||
| initial_call = Keyword.get(dictionary, :"$initial_call", initial_call) | ||
|
|
||
| format_registered_name(name) || | ||
| format_process_label(Keyword.get(dictionary, :"$process_label")) || | ||
| format_initial_call(initial_call) | ||
|
|
||
| _ -> | ||
| "-" | ||
| end | ||
| end |
There was a problem hiding this comment.
this part is adjusted from https://github.com/phoenixframework/phoenix_live_dashboard/blob/8c80084ac9d2bc417115fe00bbde0a7c66222226/lib/phoenix/live_dashboard/system_info.ex#L794-L817; I'm not 100% sure what this implies about LICENSE attribution.
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@josevalim as discussed, a first draft for a
process_infohelper in IEx.