-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add String.count/2 #14448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add String.count/2 #14448
Conversation
Co-authored-by: José Valim <[email protected]>
Co-authored-by: Jean Klingler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💜
|
This reminds me a little bit of Enum.frequencies and I’m curious if String.frequency would make for the right association. I think String.frequencies would be an easier sell but it’s obviously different functionality. I think the current name is good, especially using word count, but thought I’d mention this for completes. |
|
Apologies for the back and forth. After some discussion we decided to stick with |
|
I'd also add that, while |
|
💚 💙 💜 💛 ❤️ |
Discussed on https://groups.google.com/g/elixir-lang-core/c/JtWvn9aghgQ
The code addition itself is quite small.