Improve docs for Code module
#14456
Merged
Improve docs for Code module
#14456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 28, 2025
lib/elixir/lib/code.ex
Outdated
| Code.get_compiler_option(:debug_info) | ||
| #=> true | ||
| iex> Code.get_compiler_option(:debug_info) |
There was a problem hiding this comment.
This is reading global state and some tests may change this.
There was a problem hiding this comment.
Oh, I get it, with mix test it could be false. And put into it is even worse. Reverted, will be more careful with changes
josevalim
reviewed
Apr 28, 2025
lib/elixir/lib/code.ex
Outdated
| Code.put_compiler_option(:debug_info, true) | ||
| #=> :ok | ||
| iex> Code.put_compiler_option(:debug_info, true) |
There was a problem hiding this comment.
Same here. May affect global state. We should revert.
josevalim
reviewed
Apr 28, 2025
lib/elixir/lib/code.ex
Outdated
| iex> Code.loaded?(Atom) | ||
| true | ||
| Code.loaded?(Atom) |
There was a problem hiding this comment.
Please revert this and use a module that is likely to already be loaded, such as Enum or String. Atom indeed may not be loaded.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iex> Code.loaded?(Atom)gave race condition, at least localy.