Enum scan improvements #14486
Merged
Enum scan improvements #14486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
May 10, 2025
josevalim
reviewed
May 10, 2025
josevalim
approved these changes
May 10, 2025
josevalim
reviewed
May 20, 2025
lib/elixir/lib/enum.ex
Outdated
| ## Examples | ||
| iex> Enum.scan(["a", "b", "c", "d", "e"], &(&1 <> String.first(&2))) |
There was a problem hiding this comment.
I am thinking we should use fn elem, acc -> in those examples for clarity. WDYT?
There was a problem hiding this comment.
I thought about it and even my first attempt was to do so, and I think in the new example & is ok, but for existed one fn version seemed better, since + isn't affected by the order of arguments and it's better to explicitly point out where acc and element are
There was a problem hiding this comment.
I think we general we should prefer fn for documentation, in case someone is new to the language and they have not mastered the & notation yet?
There was a problem hiding this comment.
Sounds reasonable, will back with changes
|
💚 💙 💜 💛 ❤️ |
Nezteb
pushed a commit
to Nezteb/elixir
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't available to define arguments order in
funfrom docs and doctests, so I think it should be said excplicitly