Simplified tuple definitions by removing negations. #14596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jul 3, 2025
ggVGc
pushed a commit
to ggVGc/elixir-verbatim
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt a fully normalized representation for tuples, as union of (non-empty, see below) positive tuples. All negations are eliminated as soon as they appear.
This simplifies the code for many tuple operators.
Additionally: made tuple constructor
tuple_descrcheck emptiness of the list of types used to create a tuple. This makestuple([none(), integer()])instantly createnone(). Combined with the new representation, this allows checking for emptiness of tuple types in constant time (if the field is present, it is non-empty).