Increase test coverage of IEx ls helper and handle edge case #14626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Jul 5, 2025
|
OK the "ls existing_file" case seemed not to work Windows because it returned I think moving the check if it's a file before should fix it: 2851944. |
josevalim
approved these changes
Jul 5, 2025
ggVGc
pushed a commit
to ggVGc/elixir-verbatim
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not a very frequent case but it might be puzzling to
ls some_file/fooand get back a non-existing path.This makes it consistent with the shell
ls: