Skip to content

Prevent mix test from overriding :failures_manifest_path option #14632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

Prevent mix test from overriding :failures_manifest_path option #14632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions lib/mix/lib/mix/tasks/test.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,6 @@ defmodule Mix.Tasks.Test do
@impl true
def run(args) do
{opts, files} = OptionParser.parse!(args, strict: @switches, aliases: [b: :breakpoints])
opts = put_manifest_file(opts)

if not Mix.Task.recursing?() do
do_run(opts, args, files)
Expand Down Expand Up @@ -576,6 +575,7 @@ defmodule Mix.Tasks.Test do
Mix.Task.run("compile", args -- ["--warnings-as-errors"])

project = Mix.Project.config()

{partitions, opts} = Keyword.pop(opts, :partitions)
partitioned? = is_integer(partitions) and partitions > 1

Expand Down Expand Up @@ -667,7 +667,7 @@ defmodule Mix.Tasks.Test do
catch
kind, reason ->
# Also mark the whole suite as failed
file = Keyword.fetch!(opts, :failures_manifest_path)
file = get_manifest_path(opts)
ExUnit.Filters.fail_all!(file)
:erlang.raise(kind, reason, __STACKTRACE__)
else
Expand Down Expand Up @@ -871,7 +871,10 @@ defmodule Mix.Tasks.Test do
defp merge_helper_opts(opts) do
# The only options that are additive from app env are the excludes
value = List.wrap(Application.get_env(:ex_unit, :exclude, []))
Keyword.update(opts, :exclude, value, &Enum.uniq(&1 ++ value))

opts
|> Keyword.update(:exclude, value, &Enum.uniq(&1 ++ value))
|> Keyword.put_new_lazy(:failures_manifest_path, fn -> get_manifest_path([]) end)
end

defp default_opts(opts) do
Expand Down Expand Up @@ -918,16 +921,14 @@ defmodule Mix.Tasks.Test do

@manifest_file_name ".mix_test_failures"

defp put_manifest_file(opts) do
Keyword.put_new_lazy(
opts,
:failures_manifest_path,
fn -> Path.join(Mix.Project.manifest_path(), @manifest_file_name) end
)
defp get_manifest_path(opts) do
opts[:failures_manifest_path] ||
Application.get_env(:ex_unit, :failures_manifest_path) ||
Path.join(Mix.Project.manifest_path(), @manifest_file_name)
end

defp manifest_opts(opts) do
manifest_file = Keyword.fetch!(opts, :failures_manifest_path)
manifest_file = get_manifest_path(opts)

if opts[:failed] do
if opts[:stale] do
Expand Down