-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Revamp Mix & OTP guides #14637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Revamp Mix & OTP guides #14637
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
49ecb97
Revamp guides
josevalim e5de237
Fix warnings
josevalim 76c3d89
Add missing slash
josevalim 6437c83
Changes to new configuration and distribution
josevalim 999db85
Apply suggestions from code review
josevalim 2df3595
Apply suggestions from code review
josevalim c6aaa80
Merge branch 'main' into jv-guides-revamp
josevalim 4ca0383
Update project.ex
josevalim a590679
Apply suggestions from code review
josevalim fe7c1d6
Apply suggestions from code review
josevalim 03c6475
Apply suggestions from code review
josevalim 553014e
Apply suggestions from code review
josevalim ef3191c
More fixes
josevalim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we now explain the
child_spec
concept in a later guide, which is great. I can't think of the right wording currently, but I think we should hint at it a small bit here to make it clear thatstart_link/1
is more than just a convention, but something that Elixir expects to be defined so that it knows how to start this agent.Tried to use generic wording there to avoid explaining supervisors and child specs, but the important bit is that
start_link/1
should exist and should be calledstart_link/1
and its more than just a naming convention.