Skip to content

Conversation

@sabiwara
Copy link
Contributor

This doesn't seem relevant to dep resolution and is quite spammy:

Before
Screenshot 2025-07-12 at 9 09 24

After
Screenshot 2025-07-12 at 9 10 02

Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! And please backport!

@sabiwara sabiwara merged commit 4b09a08 into elixir-lang:main Jul 12, 2025
13 checks passed
@sabiwara sabiwara deleted the app_properties-dep-format branch July 12, 2025 12:10
@sabiwara
Copy link
Contributor Author

Backported

Sharing info below just in case there's something obvious that I missed, but feel free to ignore:

I have no idea how I ended up in this situation in the first place, I failed to come up with a repro, and it was fixed after I nuked deps so I couldn't investigate anymore 😅
But it feels weird that the converger wasn't able to figure it out, since ecto: 3.13.0, ecto_sql: 3.13.0 is a satisfying answer to ecto: "~> 3.9", ecto_sql: "~> 3.5", and it was working on 1.18.
Before I nuked deps, I observed that for some reason reverting 1f07dff seemed to fix it as well.

ggVGc pushed a commit to ggVGc/elixir-verbatim that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants