Skip to content

Restore warnings in assert/1 by not marking expressions as generated #14677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Restore warnings in assert/1 by not marking expressions as generated #14677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions lib/ex_unit/lib/ex_unit/assertions.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,16 @@ defmodule ExUnit.Assertions do
{args, value} = extract_args(assertion, __CALLER__)

quote generated: true do
if value = unquote(value) do
value
else
raise ExUnit.AssertionError,
args: unquote(args),
expr: unquote(escape_quoted(:assert, [], assertion)),
message: "Expected truthy, got #{inspect(value)}"
# not using `if` here because we don't want :generated to be propagated and suppress warnings
case unquote(value) do
falsy when falsy in [false, nil] ->
raise ExUnit.AssertionError,
args: unquote(args),
expr: unquote(escape_quoted(:assert, [], assertion)),
message: "Expected truthy, got #{inspect(falsy)}"

truthy ->
truthy
end
end
end
Expand Down Expand Up @@ -238,13 +241,16 @@ defmodule ExUnit.Assertions do
{args, value} = extract_args(assertion, __CALLER__)

quote generated: true do
if value = unquote(value) do
raise ExUnit.AssertionError,
args: unquote(args),
expr: unquote(escape_quoted(:refute, [], assertion)),
message: "Expected false or nil, got #{inspect(value)}"
else
value
# not using `if` here because we don't want :generated to be propagated and suppress warnings
case unquote(value) do
falsy when falsy in [false, nil] ->
falsy

truthy ->
raise ExUnit.AssertionError,
args: unquote(args),
expr: unquote(escape_quoted(:refute, [], assertion)),
message: "Expected false or nil, got #{inspect(truthy)}"
end
end
end
Expand Down