Skip to content

Add guards to functions in Application module #14687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

Add guards to functions in Application module #14687

merged 2 commits into from
Aug 1, 2025

Conversation

eksperimental
Copy link
Contributor

I was getting some Erlang error when passing the wrong types of arguments to Application.delete_env/3

 ** (FunctionClauseError) no function clause matching in :application.unset_env/3

 The following arguments were given to :application.unset_env/3:

     # 1
     :my_app

     # 2
     :the_key

     # 3
     nil

So this PR adds guards wherever arguments can be guarded.

sabiwara
sabiwara approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@sabiwara sabiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💜

@josevalim josevalim merged commit b5885a6 into elixir-lang:main Aug 1, 2025
13 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@eksperimental eksperimental deleted the chore/application-guards branch August 1, 2025 13:24
ggVGc pushed a commit to ggVGc/elixir-verbatim that referenced this pull request Sep 12, 2025
@eksperimental @ggVGc
Add guards to functions in Application module (elixir-lang#14687)
fecfd76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabiwara sabiwara sabiwara approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eksperimental @josevalim @sabiwara