feat - Enum.min_max sorter #14690
Merged
feat - Enum.min_max sorter #14690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Aug 3, 2025
lib/elixir/lib/enum.ex
Outdated
Comment on lines
2148
to
2149
| If multiple elements are considered maximal or minimal, the first one | ||
| that was found is returned. |
There was a problem hiding this comment.
Suggested change
| If multiple elements are considered maximal or minimal, the first one | |
| that was found is returned. | |
| By default, the comparison is done with the `<` sorter function, | |
| as the function must not return true for equal elements. |
There was a problem hiding this comment.
I have updated the text here. The code won't work if it the sorting function returns equal. Can you please apply it accordingly to min_max_by? Then we are good to go.
josevalim
reviewed
Aug 3, 2025
|
💚 💙 💜 💛 ❤️ |
Comment on lines
-2163
to
2198
| """ | ||
| @spec min_max(t, (-> empty_result)) :: {element, element} | empty_result | ||
| @spec min_max(t, (element, element -> boolean) | module()) :: | ||
| {element, element} | empty_result | ||
| when empty_result: any | ||
| @spec min_max( | ||
| t, | ||
| (element, element -> boolean) | module(), | ||
| (-> empty_result) | ||
| ) :: {element, element} | empty_result | ||
| when empty_result: any |
There was a problem hiding this comment.
Calling Enum.min_max/2 with a 0-arity anonymous function is still valid (like in the last hexdoc example) but it was removed from this function spec, shouldn't it still be documented?
There was a problem hiding this comment.
It seems we don't docuyment on the other ones but we should probably be consistent and document on them all.
ggVGc
pushed a commit
to ggVGc/elixir-verbatim
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14684
based on the logic of min_max_by