Skip to content

Fix filtering documentation #14705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

Fix filtering documentation #14705

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfe3f89
Fix filtering documentation
scohen Aug 7, 2025
c9a5e94
Apply suggestions from code review
josevalim Aug 7, 2025
d5c0b24
Update lib/logger/lib/logger.ex
josevalim Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/logger/lib/logger.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,8 +436,8 @@ defmodule Logger do
defmodule LogFilter do
def filter(log_event, _opts) do
case log_event do
%{msg: msg} when is_binary(msg) ->
if msg =~ "password" do
%{msg: {:string, msg}} ->
if ensure_binary(msg) =~ "password" do
:stop
else
:ignore
Expand All @@ -447,6 +447,14 @@ defmodule Logger do
:ignore
end
end

defp ensure_binary(charlist) when is_list(charlist) do
List.to_string(charlist)
end

defp ensure_binary(string) when is_binary(string) do
string
end
end

The filter may return the possibly modified event (to change the
Expand Down