Skip to content

ExUnit: Raise explaining what failed on invalid tags #14707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

ExUnit: Raise explaining what failed on invalid tags #14707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf98f0
ExUnit: Raise explaining what failed on invalid tags
eksperimental Aug 8, 2025
8010a51
Update lib/ex_unit/lib/ex_unit/case.ex
eksperimental Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/ex_unit/lib/ex_unit/case.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,9 +940,19 @@ defmodule ExUnit.Case do

defp normalize_tags(tags) do
Enum.reduce(Enum.reverse(tags), %{}, fn
{key, value}, acc -> Map.put(acc, key, value)
tag, acc when is_atom(tag) -> Map.put(acc, tag, true)
tag, acc when is_list(tag) -> Enum.into(tag, acc)
{key, value}, acc ->
Map.put(acc, key, value)

tag, acc when is_atom(tag) ->
Map.put(acc, tag, true)

tag, acc ->
if Keyword.keyword?(tag) do
Enum.into(tag, acc)
else
raise "an invalid value for a tag was used. " <>
"Expected an atom or a keyword list, got: #{inspect(tag)}"
end
end)
end
end