Skip to content

Fix order in ExUnit results when listing pinned variables #14723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

Fix order in ExUnit results when listing pinned variables #14723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16c2654
Fix order in ExUnit results when listing pinned variables
eksperimental Aug 26, 2025
2b76aa1
Update lib/ex_unit/lib/ex_unit/assertions.ex
eksperimental Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ex_unit/lib/ex_unit/assertions.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ defmodule ExUnit.Assertions do
def __pins__(pins) do
pins
|> Enum.filter(fn {{_, ctx}, _} -> ctx == nil end)
|> Enum.reverse()
|> Enum.sort()
|> Enum.map_join(@indent, fn {{name, _}, var} -> "#{name} = #{inspect(var)}" end)
|> case do
"" ->
Expand Down
2 changes: 1 addition & 1 deletion lib/ex_unit/test/ex_unit/assertions_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ defmodule ExUnit.AssertionsTest do
"""
Assertion failed, no matching message after 0ms
The following variables were pinned:
status = :valid
other_status = :invalid
status = :valid
Showing 1 of 1 message in the mailbox\
""" = error.message

Expand Down