Minor optimizations for Range.shift/2
#14724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Aug 28, 2025
lib/elixir/lib/range.ex
Outdated
| new(first + steps_to_shift * step, last + steps_to_shift * step, step) | ||
| def shift(range, steps_to_shift) | ||
|
|
||
| def shift(range, 0) when is_struct(range, Range), do: range |
There was a problem hiding this comment.
Suggested change
| def shift(range, 0) when is_struct(range, Range), do: range | |
| def shift(%Range{} = range, 0), do: range |
There was a problem hiding this comment.
@josevalim I wanted to ask you if there's any performance difference doing pattern matches vs is_struct/2? Or it is just a matter of style.
Personally I favor the is_struct/2 approach as it declutter the function arguments section a bit.
Co-authored-by: José Valim <[email protected]>
|
💚 💙 💜 💛 ❤️ |
ggVGc
pushed a commit
to ggVGc/elixir-verbatim
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.