Skip to content

Conversation

lukaszsamson
Copy link
Contributor

@josevalim the fix in 6a7511f is incomplete. Parser needs to be updated as well

Use %{} token meta in parser
Fixes #14740

@josevalim
Copy link
Member

Can you please provide a test? Because I am not sure I see what needs to be fixed. For the %{} token, the beginning is column: 1 (i.e. where %{ starts). Structs are different because the % and { are separate. :) Thanks!

@lukaszsamson
Copy link
Contributor Author

@josevalim if we only bump column on { token (e.g. from 1 to 2) then parser builds a %{} node taking that 2 as map column. See failed tests https://github.com/elixir-lang/elixir/actions/runs/17397565167/job/49382851600. The parser change in this PR makes it use column from %{} token and closing meta from {} pair.

@josevalim
Copy link
Member

The tests had passed locally for me. I guess the only explanation is that I forgot to save the file before running them. 🤦

@josevalim
Copy link
Member

Thank you, however, I will just review the previous PR, given the tokenizer is private API and that's simpler than doing the token dance here. :)

@josevalim josevalim closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect column meta on { in map token

2 participants