Skip to content

Conversation

artkay
Copy link
Contributor

@artkay artkay commented Sep 8, 2025

This PR replaces the Enum.filter |> Enum.map chain in Access.filter with a more efficient for comprehension that eliminates unnecessary intermediate list creation, which (I believe) should be a somewhat meaningful improvement for large lists.

The tests for the module pass locally:

$> bin/elixir lib/elixir/test/elixir/access_test.exs
Running ExUnit with seed: 375552, max_cases: 20
Excluding tags: [:re_import, {:windows, true}, {:distributed, true}]

...............................................................................................
Finished in 0.1 seconds (0.09s on load, 0.01s async, 0.00s sync)
54 doctests, 41 tests, 0 failures

@josevalim josevalim merged commit 469a1cc into elixir-lang:main Sep 8, 2025
13 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants