ExUnit sets a process label for each test #14758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 9, 2025
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Sep 9, 2025
sabiwara
reviewed
Sep 9, 2025
| context | ||
| ) do | ||
| spawn_monitor(fn -> | ||
| Process.set_label({test.case, test.name}) |
There was a problem hiding this comment.
Might be overthinking this, but perhaps we could have an extra atom to make it distinguishable programmatically?
- Process.set_label({test.case, test.name})
+ Process.set_label({:ex_unit, test.case, test.name})
There was a problem hiding this comment.
I thought so but the module name should be self explanatory in most cases as it ends with Test by convention!
There was a problem hiding this comment.
Makes sense, although it doesn't cost much and also might have the benefit of grouping ex_unit tests together nicely if there is any sorting? Anyway, no strong opinion here 🙂
There was a problem hiding this comment.
@sabiwara I saw this later. I like the idea. PR: Make this process label clearer
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: DbConnection PR Use process labels