Skip to content

Conversation

eksperimental
Copy link
Contributor

This is an automated commit created by the Maintenance project https://github.com/eksperimental/maintenance

Before merging, please read the release notes by visiting http://www.unicode.org/versions/Unicode17.0.0/
and assess if additional changes are necessary in the code base.

This is an automated commit created by the Maintenance project
https://github.com/eksperimental/maintenance

Before merging, please read the release notes by visiting
<http://www.unicode.org/versions/Unicode17.0.0/>
and assess if additional changes are necessary in the code base.
@eksperimental
Copy link
Contributor Author

eksperimental commented Sep 10, 2025

A test is failing.

iex(1)>  Code.eval_string("幻ㄒㄧㄤ = 1")
** (SyntaxError) invalid syntax found on nofile:1:2:
    error: unexpected token: "ㄒ" (column 2, code point U+3112)1 │ 幻ㄒㄧㄤ = 1^
    │
    └─ nofile:1:2
    (elixir 1.20.0-dev) lib/code.ex:628: Code.validated_eval_string/3
    iex:1: (file)

@kipcole9
Copy link
Contributor

Excepting this test, is it too late to include in Elixir 1.19?

PS: Great to see your automation work so well.

@josevalim
Copy link
Member

Thank you.

Unicode 17 no longer recommends Bopomofo characters in identifiers, hence the failure. If you allow me to push to your fork, I can fix this PR, otherwise I will submit a new one.

@eksperimental
Copy link
Contributor Author

If you allow me to push to your fork, I can fix this PR, otherwise I will submit a new one.

I have added you as a contributor. You should have received the invitation.

@josevalim
Copy link
Member

@eksperimental thank you! I don't need to be a maintainer though, I only need enough permissions to push to this PR! :)

@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants