Skip to content

Deal with relative paths in mix cmd, closes #14787 #14788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Deal with relative paths in mix cmd, closes #14787 #14788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/mix/lib/mix/tasks/cmd.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,19 @@ defmodule Mix.Tasks.Cmd do
end

if apps == [] or Mix.Project.config()[:app] in apps do
path = hd(args)
rest = tl(args)

path =
if String.contains?(path, ["/", "\\"]) and Path.type(path) != :absolute do
Path.expand(path, Keyword.get(opts, :cd, "."))
else
path
end

cmd_opts = Keyword.take(opts, [:cd])

case Mix.shell().cmd({hd(args), tl(args)}, cmd_opts) do
case Mix.shell().cmd({path, rest}, cmd_opts) do
0 -> :ok
status -> exit(status)
end
Expand Down
15 changes: 15 additions & 0 deletions lib/mix/test/mix/tasks/cmd_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,21 @@ defmodule Mix.Tasks.CmdTest do
assert_received {:mix_shell, :run, ["hello world\n"]}
end

@tag :unix
test "supports relative paths" do
in_tmp("cmd-relative", fn ->
File.mkdir_p!("priv")
File.write!("priv/world.sh", "#!/bin/sh\necho world")
File.chmod!("priv/world.sh", 0o755)

Mix.Task.run("cmd", ["priv/world.sh"])
assert_received {:mix_shell, :run, ["world\n"]}

Mix.Task.run("cmd", ["--cd", "priv", "./world.sh"])
assert_received {:mix_shell, :run, ["world\n"]}
end)
end

test "runs the command for each app" do
in_fixture("umbrella_dep/deps/umbrella", fn ->
Mix.Project.in_project(:umbrella, ".", fn _ ->
Expand Down