Skip to content

Conversation

josevalim
Copy link
Member

Closes #1969.

@josevalim
Copy link
Member Author

@DavidOliver, this was added in 3189db6, so I am pinging you to see if you are happy with this revert. :)

@DavidOliver
Copy link
Contributor

@josevalim, thanks. This seems to result in the hover link for the fragment only showing when it itself is hovered, and not when the heading is hovered, which I think is not ideal.

Shall we aim for the hover link to show when either the heading or the hover link is hovered, but to leave the heading selectable, requiring pointing to the hover link icon itself to use the fragment link? I can have a look at doing that if there is agreement.

@josevalim
Copy link
Member Author

Great catch!

Shall we aim for the hover link to show when either the heading or the hover link is hovered, but to leave the heading selectable, requiring pointing to the hover link icon itself to use the fragment link? I can have a look at doing that if there is agreement.

Yes, please!

@josevalim josevalim closed this Nov 26, 2024
@josevalim josevalim deleted the jv-pointer-events branch November 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Unable to select heading text

2 participants