Document the requirement to push releases#2109
Merged
josevalim merged 3 commits intoelixir-lang:mainfrom Apr 13, 2025
Merged
Conversation
Currently there isn't any documentation about the requirement to push releases/tags to the `source_url` to get links to specific versions of the code. So this PR adds this documentation. I couldn't find a general spot where `source_url` is talked about so I added an admonition near where it is first introduced.
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/14422686265/artifacts/2933377055 |
josevalim
reviewed
Apr 6, 2025
Co-authored-by: José Valim <jose.valim@gmail.com>
Contributor
Author
|
@josevalim okay I've extracted this to a new section and it is now ready for another look! |
Member
|
💚 💙 💜 💛 ❤️ |
rafaeelaudibert
added a commit
to PostHog/posthog-elixir
that referenced
this pull request
Apr 14, 2025
Besides including the `source_url` added in #14, let's also add some images and include `source_ref` - per elixir-lang/ex_doc#2109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there isn't any documentation about the requirement to push releases/tags to the
source_urlto get links to specific versions of the code. So this PR adds this documentation.I couldn't find a general spot where
source_urlis talked about so I added an admonition near where it is first introduced.Background: recently (in PostHog/posthog-elixir#14 (comment)) I was asked where the requirement for pushing git tags comes from. I wasn't able to find any official documentation (here or in https://hexdocs.pm/elixir/writing-documentation.html) so I have created this PR.
Here's what it looks like when I build the documentation locally:
