Skip to content

Correctly decode sidebar ids #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Correctly decode sidebar ids #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions assets/js/sidebar/sidebar-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { el, getCurrentPageSidebarType, qs, qsAll } from '../helpers'
import { getSidebarNodes } from '../globals'
import he from 'he'

// Sidebar list is only rendered when needed.
// Mobile users may never see the sidebar.
Expand Down Expand Up @@ -122,7 +123,7 @@ function renderHeaders (node) {
return node.headers
.map(({id, anchor}) =>
el('li', {}, [
el('a', {href: `${node.id}.html#${anchor}`}, [id])
el('a', {href: `${node.id}.html#${anchor}`}, [he.decode(id)])
])
)
}
Expand All @@ -137,7 +138,7 @@ function renderSectionsAndGroups (node) {
node.sections
.map(({id, anchor}) =>
el('li', {}, [
el('a', {href: `${node.id}.html#${anchor}`}, [id])
el('a', {href: `${node.id}.html#${anchor}`}, [he.decode(id)])
])
)
)
Expand All @@ -156,7 +157,7 @@ function renderSectionsAndGroups (node) {
nodes
.map(({anchor, title, id}) =>
el('li', {}, [
el('a', {href: `${node.id}.html#${anchor}`, title, translate: 'no'}, [id])
el('a', {href: `${node.id}.html#${anchor}`, title, translate: 'no'}, [he.decode(id)])
])
)
)
Expand Down
1 change: 1 addition & 0 deletions assets/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"eslint-plugin-promise": "^6.1.1",
"fs-extra": "^11.1.0",
"handlebars": "^4.7.7",
"he": "^1.2.0",
"karma": "^6.4.1",
"karma-chai-plugins": "^0.9.0",
"karma-chrome-launcher": "^3.1.1",
Expand Down
226 changes: 226 additions & 0 deletions formatters/html/dist/html-6A6YBAOQ.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading