docs: update Lexical -> Expert in install instructions#53
docs: update Lexical -> Expert in install instructions#53doorgan merged 2 commits intoelixir-lang:mainfrom
Conversation
pages/installation.md
Outdated
| download the latest version of Lexical. | ||
| download the latest version of Expert. | ||
|
|
||
| To change to a local executable, go to `Settings -> Extensions -> Lexical` and | ||
| To change to a local executable, go to `Settings -> Extensions -> Expert` and |
There was a problem hiding this comment.
I believe these ones are supposed to be Lexical still since the Lexical extension is being used.
There was a problem hiding this comment.
I've noticed that getting it running locally. In neovim, if I set lspconfig.expert.setup { ... it wouldn't work, but lspconfig.lexical.setup did. I'm happy to help out with any other renaming stuff
There was a problem hiding this comment.
For the VSCode extension, we should keep Lexical here since that's the extension that is compatible with Expert at the moment, we need a new Expert vscode extension
On Neovim this is my configuration: https://github.com/doorgan/dotfiles/blob/main/dot_config/nvim/lua/plugins/lsp-config.lua#L26-L55 we should update the docs to be more inline with this
There was a problem hiding this comment.
From the nvim-lspconfigs github, it appears that require('lspconfig') is deprecated now? https://github.com/andyleclair/nvim-lspconfig?tab=readme-ov-file#important-%EF%B8%8F
IMO, if that's what they're saying, it's what we should say?
There was a problem hiding this comment.
IMO, if that's what they're saying, it's what we should say?
@andyleclair agreed
There was a problem hiding this comment.
Ok, I have this configured in my config, confirmed working in neovim 0.11.3
https://github.com/andyleclair/.dotfiles/blob/main/.config/nvim/lua/custom/plugins/elixir.lua
If you like, I can update the docs for that? I've got a PR cooking for nvim-lspconfig that essentially has the same stuff, I just wanted to make sure it worked first!
There was a problem hiding this comment.
Awesome, let's do it, thank you! 💜
|
Should we tell people to put the release on their |
That sounds useful, we can add that! |
Noticed a few places in the install docs where
Lexicalshould beExpert