Skip to content

docs: update Lexical -> Expert in install instructions#53

Merged
doorgan merged 2 commits intoelixir-lang:mainfrom
andyleclair:main
Aug 29, 2025
Merged

docs: update Lexical -> Expert in install instructions#53
doorgan merged 2 commits intoelixir-lang:mainfrom
andyleclair:main

Conversation

@andyleclair
Copy link
Contributor

Noticed a few places in the install docs where Lexical should be Expert

@andyleclair andyleclair changed the title update Lexical -> Expert in install instructions docs: update Lexical -> Expert in install instructions Aug 28, 2025
Comment on lines 145 to 147
download the latest version of Lexical.
download the latest version of Expert.

To change to a local executable, go to `Settings -> Extensions -> Lexical` and
To change to a local executable, go to `Settings -> Extensions -> Expert` and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these ones are supposed to be Lexical still since the Lexical extension is being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that getting it running locally. In neovim, if I set lspconfig.expert.setup { ... it wouldn't work, but lspconfig.lexical.setup did. I'm happy to help out with any other renaming stuff

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the VSCode extension, we should keep Lexical here since that's the extension that is compatible with Expert at the moment, we need a new Expert vscode extension

On Neovim this is my configuration: https://github.com/doorgan/dotfiles/blob/main/dot_config/nvim/lua/plugins/lsp-config.lua#L26-L55 we should update the docs to be more inline with this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the nvim-lspconfigs github, it appears that require('lspconfig') is deprecated now? https://github.com/andyleclair/nvim-lspconfig?tab=readme-ov-file#important-%EF%B8%8F

IMO, if that's what they're saying, it's what we should say?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, if that's what they're saying, it's what we should say?

@andyleclair agreed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have this configured in my config, confirmed working in neovim 0.11.3

https://github.com/andyleclair/.dotfiles/blob/main/.config/nvim/lua/custom/plugins/elixir.lua

image

If you like, I can update the docs for that? I've got a PR cooking for nvim-lspconfig that essentially has the same stuff, I just wanted to make sure it worked first!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's do it, thank you! 💜

@andyleclair
Copy link
Contributor Author

andyleclair commented Aug 28, 2025

Should we tell people to put the release on their PATH (like in ~/.local/bin/expert)? If we did that, we could set the cmd in nvim-lspconfig and it should just work?

@doorgan
Copy link
Collaborator

doorgan commented Aug 29, 2025

Should we tell people to put the release on their PATH (like in ~/.local/bin/expert)? If we did that, we could set the cmd in nvim-lspconfig and it should just work?

That sounds useful, we can add that!

@andyleclair andyleclair requested a review from doorgan August 29, 2025 01:58
Copy link
Collaborator

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💜

@doorgan doorgan merged commit 6191aa6 into elixir-lang:main Aug 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments