do not return snippet for "do" reserved word if client doesn't support snippets #1136
Conversation
| if Keyword.get(options, :snippets_supported, false) do | ||
| "do\n $0\nend" | ||
| else | ||
| "do" |
There was a problem hiding this comment.
It's possible to return "do\n " here, but I'm not sure - for my use-case (Emacs and lsp-mode) pressing return after plain do automatically inserts matching end, so if elixir-ls returns plain do then I can just press return twice to get the desired result (otherwise I will have to type end manually).
|
Doesn’t other reserved keywords need similar changes? |
|
Possibly, but it's my first contribution and I wanted to take it slow. Currently, for me typing some other reserved keywords (else, cond, case) results in an exception somewhere deep inside elixir-ls, so I planned to tackle it in a separate issue. |
|
I see lots of CI tests failing. Looked at the logs and it seems to me that errors are not caused by my changes - am I correct? |
|
Thanks |
2 participants
I'm using Emacs and lsp-mode, and absense of "do" from completions really hurts - closest match in completions is "defoverridable", so every time I want to type "do" I have to type "do", cancel the completions dialog and only then press return.
This PR adds check for
snippets_supportedand returns a simple non-snippet response if necessary.