Skip to content

Handle missing version in extra doc links #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Handle missing version in extra doc links #1194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/language_server/lib/language_server/markdown_utils.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,14 @@ defmodule ElixirLS.LanguageServer.MarkdownUtils do
end

if app_vsn do
{app, _vsn} = app_vsn
app =
case app_vsn do
{app, _vsn} ->
app

app when is_atom(app) or is_binary(app) ->
app
end

if app in @all_otp_apps and @erlang_ex_doc? do
# TODO not sure hos the docs will handle versions app/vsn does not work as of June 2024
Expand Down
6 changes: 6 additions & 0 deletions apps/language_server/test/markdown_utils_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,12 @@ defmodule ElixirLS.LanguageServer.MarkdownUtilsTest do
) == "[Up and running](http://example.com/foo.md)"
end

test "extra page unknown app" do
assert MarkdownUtils.transform_ex_doc_links(
"[Up](e:unknown_app:foo.md)"
) == "[Up](https://hexdocs.pm/unknown_app/foo.html)"
end

if System.otp_release() |> String.to_integer() >= 27 do
test "erlang extra page" do
assert MarkdownUtils.transform_ex_doc_links(
Expand Down
Loading