Skip to content

Handle embedded-content #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Handle embedded-content #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/languageClientManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,21 @@ import {
reporter,
} from "./telemetry";

const languageIds = ["elixir", "eex", "html-eex", "phoenix-heex", "surface"];
// Languages fully handled by this extension
const languageIds = ["elixir", "eex", "html-eex", "phoenix-heex"];

// Template languages handled by their own extensions but require activation of this
// one for compiler diagnostics. Template languages that compile down to Elixir AST
// and embed other languages (e.g. HTML, CSS, JS and Elixir itself), should be moved
// here for proper language service forwarding via "embedded-content".
const templateLanguageIds = ["surface"];
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"html-eex" and "phoenix-heex" should eventually be moved here.


const activationLanguageIds = languageIds.concat(templateLanguageIds);

const defaultDocumentSelector = languageIds.flatMap((language) => [
{ language, scheme: "file" },
{ language, scheme: "untitled" },
{ language, scheme: "embedded-content" },
]);

const untitledDocumentSelector = languageIds.map((language) => ({
Expand Down Expand Up @@ -348,7 +359,7 @@ export class LanguageClientManager {
context: vscode.ExtensionContext,
) {
// We are only interested in elixir related files
if (!languageIds.includes(document.languageId)) {
if (!activationLanguageIds.includes(document.languageId)) {
return;
}

Expand Down
Loading