Fix compile-time warnings for Elixir 1.19.1#616
Closed
dimamik wants to merge 1 commit intoelixir-nx:mainfrom
Closed
Fix compile-time warnings for Elixir 1.19.1#616dimamik wants to merge 1 commit intoelixir-nx:mainfrom
dimamik wants to merge 1 commit intoelixir-nx:mainfrom
Conversation
Contributor
|
Woot, it found an actual bug :) |
polvalente
reviewed
Oct 29, 2025
Contributor
Author
Can you elaborate more? The code seems legit... |
Contributor
|
@dimamik I meant this warning is an actual bug: It needs to be fixed. :) |
Contributor
polvalente
added a commit
that referenced
this pull request
Nov 14, 2025
Co-Authored-By: Dima Mikielewicz <dymitrmikielewicz@gmail.com>
polvalente
added a commit
that referenced
this pull request
Nov 14, 2025
* chore: update nx * fix doctests * fix: update ci * chore: format * fix: tolerances * fix: formatter * fix: tolerances * fix: tolerances * chore: bring changes from #616 Co-Authored-By: Dima Mikielewicz <dymitrmikielewicz@gmail.com> * chore: format * fix: flaky test --------- Co-authored-by: Dima Mikielewicz <dymitrmikielewicz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all compile-time warnings for Elixir 1.19.1: