feat: add is_protobuf_message/1 guard for message identification #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add __protobuf__: true marker to all protobuf message structs and create an is_protobuf_message/1 guard macro, following Elixir's convention for is_exception/1. This enables efficient, idiomatic checking of protobuf messages in guards and pattern matching. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/is-proto-message
branch
from
35bb03e to
99f290e
Compare
Contributor
Author
|
I came across few times where I want to ensure protos are passed down. With latest Elixir typecheck, hopefully this guard helps even more. |
Contributor
Author
|
@whatyouhide another one for you 😄 |
Collaborator
|
Thank you @yordis 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
__protobuf__: truemarker to all protobuf message structs and create anis_protobuf_message/1guard macro, following Elixir's convention foris_exception/1. This enables efficient, idiomatic checking of protobuf messages in guards and pattern matching.Signed-off-by: Yordis Prieto yordis.prieto@gmail.com