Skip to content

Fix race condition in Tesla.Mock.agent_set #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 1 commit into from
Apr 28, 2025
Merged

Fix race condition in Tesla.Mock.agent_set #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions lib/tesla/mock.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,18 +238,24 @@ defmodule Tesla.Mock do
end

defp agent_set(fun) do
case Process.whereis(__MODULE__) do
nil ->
ExUnit.Callbacks.start_supervised!(
%{
id: __MODULE__,
start: {Agent, :start_link, [fn -> fun end, [{:name, __MODULE__}]]}
},
[]
)

pid ->
mock_start_result =
ExUnit.Callbacks.start_supervised(
%{
id: __MODULE__,
start: {Agent, :start_link, [fn -> fun end, [{:name, __MODULE__}]]}
},
[]
)

case mock_start_result do
{:ok, _pid} ->
:ok

{:error, {:already_started, pid}} ->
Agent.update(pid, fn _ -> fun end)

other ->
raise other
end
end

Expand Down
Loading